Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CAPI to v1.5.2 #4041

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Update CAPI to v1.5.2 #4041

merged 1 commit into from
Sep 28, 2023

Conversation

mboersma
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates CAPI references to use the new v1.5.2 release.

Also updates cert-manager to v1.13.0 to keep that in sync with CAPI.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Update CAPI to v1.5.2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2023
@mboersma
Copy link
Contributor Author

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot
Copy link

@mboersma: once the present PR merges, I will cherry-pick it on top of release-1.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2b4af17) 56.57% compared to head (bbb7f0e) 56.57%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4041   +/-   ##
=======================================
  Coverage   56.57%   56.57%           
=======================================
  Files         187      187           
  Lines       19130    19130           
=======================================
  Hits        10823    10823           
  Misses       7676     7676           
  Partials      631      631

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jont828
Copy link
Contributor

Jont828 commented Sep 26, 2023

LGTM pending test failure

@Jont828
Copy link
Contributor

Jont828 commented Sep 26, 2023

It seems like you're having a regex failure:

Expected
        <*errors.errorString | 0xc00577fa50>: 
        failed to match regexp "GET /echo\\?msg=prestop" in output "I0[926](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/4041/pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts/1706793339065470976#1:build-log.txt%3A926) 22:49:04.855003   15684 log.go:194] Started HTTP server on port 8080\nI0926 22:49:05.028477   15684 log.go:194] Started UDP server on port  8081\n"
        {
            s: "failed to match regexp \"GET /echo\\\\?msg=prestop\" in output \"I0926 22:49:04.855003   15684 log.go:194] Started HTTP server on port 8080\\nI0926 22:49:05.028477   15684 log.go:194] Started UDP server on port  8081\\n\"",
        }
    to be nil

@Jont828
Copy link
Contributor

Jont828 commented Sep 26, 2023

/retest

@mboersma
Copy link
Contributor Author

/retest

This time, 0 out of 2 machines in the deployment were ready. 🤷

nojnhuh
nojnhuh reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7e9e03883c41642ca9b45b1fd128361cf830796c

willie-yao
willie-yao approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@nojnhuh
Copy link
Contributor

nojnhuh commented Sep 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff21c16 into kubernetes-sigs:main Sep 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 28, 2023
@k8s-infra-cherrypick-robot
Copy link

@mboersma: new pull request created: #4046

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 28, 2023
Merged
@mboersma mboersma deleted the capi-one-five-two branch September 28, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@willie-yao willie-yao willie-yao approved these changes

@Jont828 Jont828 Awaiting requested review from Jont828

@marosset marosset Awaiting requested review from marosset

Assignees

@nojnhuh nojnhuh

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@mboersma @k8s-infra-cherrypick-robot @Jont828 @k8s-ci-robot @nojnhuh @willie-yao